Unity

Merge lp://qastaging/~thumper/unity/hud-alt-tap into lp://qastaging/unity

  1. hud-alt-tap
  2. Merge into trunk
Proposed by Tim Penhey
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: no longer in the source branch.
Merged at revision: 2041
Proposed branch: lp://qastaging/~thumper/unity/hud-alt-tap
Merge into: lp://qastaging/unity
Diff against target: 239 lines (+90/-56)
5 files modified
plugins/unityshell/src/LauncherController.cpp (+2/-2)
plugins/unityshell/src/LauncherController.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+46/-27)
tests/autopilot/autopilot/emulators/unity/hud.py (+2/-2)
tests/autopilot/autopilot/tests/test_hud.py (+39/-24)
To merge this branch: bzr merge lp://qastaging/~thumper/unity/hud-alt-tap
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
Mirco Müller (community) Approve
Review via email: mp+93331@code.qastaging.launchpad.net

Commit message

Uses the new modifier-tap ability in compiz to only show the HUD if someone hasn't used another key with alt (or the associated key).

Description of the change

Uses the new modifier-tap ability in compiz to only show the HUD if someone hasn't used another key with alt (or the associated key).

Needs lp:compiz-core r3003 or above.

UNBLOCK

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

I like these kind of lines :)

  LOG_ERROR(logger) << "this should never happen";

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/336/console reported an error when processing this lp:~thumper/unity/hud-alt-tap branch.
Not merging it.

Revision history for this message
Tim Penhey (thumper) wrote :

Moving this to work in progress until the compiz branch is ready.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

My name is Thomi, and I approve this merge proposal.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/365/console reported an error when processing this lp:~thumper/unity/hud-alt-tap branch.
Not merging it.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Still looks damn sexy.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/368/console reported an error when processing this lp:~thumper/unity/hud-alt-tap branch.
Not merging it.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The bot will recognize its master ;)

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/370/console reported an error when processing this lp:~thumper/unity/hud-alt-tap branch.
Not merging it.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

for the record: it took 17 minutes for compiz uploaded in the staging ppa once built to be available to the QA lab (proxy/mirroring issue?). Anyway, to avoid such skews, I think that shows that adding compiz to the autolanding process is needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.