Unity

Merge lp://qastaging/~thumper/unity/unity.fix-alt-tab-mm-confusion into lp://qastaging/unity

  1. unity.fix-alt-tab-mm-confusion
  2. Merge into trunk
Proposed by Tim Penhey
Status: Merged
Approved by: Jason Smith
Approved revision: no longer in the source branch.
Merged at revision: 2038
Proposed branch: lp://qastaging/~thumper/unity/unity.fix-alt-tab-mm-confusion
Merge into: lp://qastaging/unity
Prerequisite: lp://qastaging/~jassmith/unity/unity.fix-alt-tab-progression
Diff against target: 163 lines (+54/-19)
4 files modified
.bzrignore (+1/-0)
plugins/unityshell/src/SwitcherController.cpp (+2/-2)
tests/autopilot/autopilot/tests/__init__.py (+2/-0)
tests/autopilot/autopilot/tests/test_switcher.py (+49/-17)
To merge this branch: bzr merge lp://qastaging/~thumper/unity/unity.fix-alt-tab-mm-confusion
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Thomi Richards (community) Approve
Review via email: mp+95092@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-02-22.

Commit message

Fix the details mode in alt-tab over multiple workspaces and monitors.

Description of the change

= The Problem =
Alt-tab would get stuck in detail mode when two windows on different monitors were open

= The Fix =
Don't leak the DetailXids() abstraction from the SwitcherModel. The assumed internal implementation changed, breaking SwitcherController

= Testing =

Added autopilot tests SwitcherDetailsTests

UNBLOCK

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote : Posted in a previous version of this proposal

Doesn't contain tests

review: Needs Fixing
Revision history for this message
Tim Penhey (thumper) wrote : Posted in a previous version of this proposal

Lets start with a manual test with detailed description of how to set up the environment.

From there we'll work to make a simple AP test.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

+42

review: Approve
Revision history for this message
Jason Smith (jassmith) wrote :

Thanks tim

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.