Merge lp://qastaging/~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat into lp://qastaging/gsettings-ubuntu-touch-schemas

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 55
Merged at revision: 55
Proposed branch: lp://qastaging/~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat
Merge into: lp://qastaging/gsettings-ubuntu-touch-schemas
Diff against target: 12 lines (+1/-1)
1 file modified
schemas/com.ubuntu.phone.gschema.xml.in.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~tiagosh/gsettings-ubuntu-touch-schemas/enable-group-chat
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Review via email: mp+259682@code.qastaging.launchpad.net

Commit message

Enable mms group chat by default

Description of the change

Enable mms group chat by default

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that seems fine to me but I've some questions...
- why that not enabled by default before? What is the cost/side effect of enabling it?
- do we still have a reason we want to turn that off?

if it's enabled by default and always makes sense/has no user configuration UI maybe it doesn't need to be an option anymore?

review: Needs Information
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

thanks for the review,

- the option was disabled by default because the mms group chat feature wasn't fully implemented.
- users that don't have mms support might want to disable it, so they can send multi-recipient sms messages instead of mms group chats.

The settings screen is implemented in messaging-app:
https://code.launchpad.net/~tiagosh/messaging-app/messaging-settings-page/+merge/257832

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for the reply!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches