messaging-app

Merge lp://qastaging/~tiagosh/messaging-app/fix_leaks_and_empty_view into lp://qastaging/messaging-app

  1. fix_leaks_and_empty_view
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 518
Merged at revision: 529
Proposed branch: lp://qastaging/~tiagosh/messaging-app/fix_leaks_and_empty_view
Merge into: lp://qastaging/messaging-app
Diff against target: 304 lines (+128/-14)
9 files modified
src/messagingapplication.cpp (+5/-0)
src/messagingapplication.h (+1/-0)
src/qml/MMS/Previewer.qml (+11/-0)
src/qml/Messages.qml (+11/-7)
src/qml/MessagingBottomEdge.qml (+6/-0)
src/qml/MessagingPageLayout.qml (+13/-0)
src/qml/SettingsPage.qml (+28/-0)
src/qml/messaging-app.qml (+24/-7)
tests/qml/tst_MessagesView.qml (+29/-0)
To merge this branch: bzr merge lp://qastaging/~tiagosh/messaging-app/fix_leaks_and_empty_view
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287247@code.qastaging.launchpad.net

Commit message

- Fix some memory leaks
- Use another approach to decide when to display the empty state view
- Avoid removing pages when resizing the AdaptivePageLayout

Description of the change

- Fix some memory leaks
- Use another approach to decide when to display the empty state view
- Avoid removing pages when resizing the AdaptivePageLayout

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:517
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/965/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6655/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/474/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6666/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/965/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~tiagosh/messaging-app/fix_leaks_and_empty_view updated
518. By Tiago Salem Herrmann

fix qml test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:518
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/966/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6669/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/475/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6680/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/966/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
lp://qastaging/~tiagosh/messaging-app/fix_leaks_and_empty_view updated
519. By Tiago Salem Herrmann

avoid name collision

520. By Tiago Salem Herrmann

use a different name to avoid collision

521. By Tiago Salem Herrmann

reimplement findChild() to avoid test failure

522. By Tiago Salem Herrmann

destroy is asynchronous, so change the objectName

523. By Tiago Salem Herrmann

remove settings page from the stack

524. By Tiago Salem Herrmann

fix id of item

525. By Tiago Salem Herrmann

add 1ms delay to destroy

526. By Tiago Salem Herrmann

avoid redundant call

527. By Tiago Salem Herrmann

force destroy previewer views

528. By Tiago Salem Herrmann

merge trunk

529. By Tiago Salem Herrmann

only display 2 columns when width > units.gu(90)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches