Merge lp://qastaging/~tiagosh/messaging-app/update-translations into lp://qastaging/messaging-app

Proposed by Tiago Salem Herrmann
Status: Rejected
Rejected by: Bill Filler
Proposed branch: lp://qastaging/~tiagosh/messaging-app/update-translations
Merge into: lp://qastaging/messaging-app
Diff against target: 180 lines (+55/-37)
1 file modified
po/messaging-app.pot (+55/-37)
To merge this branch: bzr merge lp://qastaging/~tiagosh/messaging-app/update-translations
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
David Planella (community) Approve
Tiago Salem Herrmann Pending
Review via email: mp+225820@code.qastaging.launchpad.net

Commit message

Update pot files.

Description of the change

Update pot files.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/messaging-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Why are all the .po files updated on this MP? Only the .pot needs to be updated. Launchpad takes care of all the rest, and the updated .po files for the new template are then auto-committed in the daily exports.

review: Needs Information
129. By Tiago Salem Herrmann

revert

130. By Tiago Salem Herrmann

update pot file

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

> Why are all the .po files updated on this MP? Only the .pot needs to be
> updated. Launchpad takes care of all the rest, and the updated .po files for
> the new template are then auto-committed in the daily exports.

Oops, my fault.
Just committed the right changes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

LGTM, thanks!

review: Approve
131. By Tiago Salem Herrmann

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

131. By Tiago Salem Herrmann

merge trunk

130. By Tiago Salem Herrmann

update pot file

129. By Tiago Salem Herrmann

revert

128. By Tiago Salem Herrmann

update pot files

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches