Merge lp://qastaging/~tiagosh/ubuntu/trusty/telepathy-qt5/class0sms into lp://qastaging/ubuntu/trusty/telepathy-qt5

Proposed by Tiago Salem Herrmann
Status: Merged
Merged at revision: 9
Proposed branch: lp://qastaging/~tiagosh/ubuntu/trusty/telepathy-qt5/class0sms
Merge into: lp://qastaging/ubuntu/trusty/telepathy-qt5
Diff against target: 3613 lines (+3515/-2)
12 files modified
.pc/09-add_sms_iface_service_side.patch/TelepathyQt/base-channel-internal.h (+418/-0)
.pc/09-add_sms_iface_service_side.patch/TelepathyQt/base-channel.cpp (+2001/-0)
.pc/09-add_sms_iface_service_side.patch/TelepathyQt/base-channel.h (+591/-0)
.pc/09-add_sms_iface_service_side.patch/TelepathyQt/service-types.h (+103/-0)
.pc/applied-patches (+1/-0)
TelepathyQt/base-channel-internal.h (+25/-0)
TelepathyQt/base-channel.cpp (+106/-2)
TelepathyQt/base-channel.h (+39/-0)
TelepathyQt/service-types.h (+2/-0)
debian/changelog (+6/-0)
debian/patches/09-add_sms_iface_service_side.patch (+222/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~tiagosh/ubuntu/trusty/telepathy-qt5/class0sms
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Needs Fixing
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+214099@code.qastaging.launchpad.net

Commit message

Add SMS service side class.

Description of the change

Add SMS service side class to properly implement support for class 0 sms's.

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Code looks good and works as expected!

review: Approve
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Please add a minimal header to the patch, so we can better track the reason why we have it applied in the package itself. Check http://dep.debian.net/deps/dep3/ for guidelines.

review: Needs Fixing
11. By Tiago Salem Herrmann

update patch file to be debian compliant

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches