unity-2d

Merge lp://qastaging/~tiagosh/unity-2d/bugfix-838708 into lp://qastaging/unity-2d

bugfix-838708
Merge into trunk

Proposed by Tiago Salem Herrmann on 2011-12-14

Status:	Merged
Approved by:	Lohith D Shivamurthy on 2011-12-21
Approved revision:	829
Merged at revision:	834
Proposed branch:	lp://qastaging/~tiagosh/unity-2d/bugfix-838708
Merge into:	lp://qastaging/unity-2d
Diff against target:	73 lines (+13/-2) 2 files modified launcher/LauncherItem.qml (+11/-2) launcher/LauncherList.qml (+2/-0)
To merge this branch:	bzr merge lp://qastaging/~tiagosh/unity-2d/bugfix-838708
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Lohith D Shivamurthy (community)		2011-12-14	Approve on 2011-12-21
Review via email: mp+85677@code.qastaging.launchpad.net

Description of the change

This merge request intends to fix lp:838708, making BFB behavior and visual match the design.

lp://qastaging/~tiagosh/unity-2d/bugfix-838708 updated on 2011-12-14

828. By Tiago Salem Herrmann on 2011-12-14: [launcher] make bfb totally opaque while the launcher background design is not fully implemented

Revision history for this message

Lohith D Shivamurthy (dyams) wrote on 2011-12-20:

Hey Tiagosh, You have effectively removed the 'tileBackground' in LauncherItem by setting its opacity to zero.
Now its useful only while animating 'launching'.
Is that correct? Could you please check it again?

review: Needs Information (code)

lp://qastaging/~tiagosh/unity-2d/bugfix-838708 updated on 2011-12-20

829. By Tiago Salem Herrmann on 2011-12-20: [launcher] fix previous commit. Make it fully opaque by setting it to 1

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2011-12-20:

It was a mistake. Just fixed.

Revision history for this message

Lohith D Shivamurthy (dyams) wrote on 2011-12-21:

> It was a mistake. Just fixed.

Thank you.
You have removed the blend effect for 'BFB' tileBackground.
File LauncherItem.qml, Line #215
The other tiles have that effect still.
Is that intentional? Bug report says that that effect is needed for BFB though.

Revision history for this message

Gerry Boland (gerboland) wrote on 2011-12-21:

Yes its intentional. Since we are missing the blurred & tinted background, the blend effect makes the BFB very hard to see. This is a compromise for now.

Revision history for this message

Lohith D Shivamurthy (dyams) wrote on 2011-12-21:

> Yes its intentional. Since we are missing the blurred & tinted background, the
> blend effect makes the BFB very hard to see. This is a compromise for now.
OK, I agree with you.

Looking good and It is good to approve this already.
Approving.

review: Approve