unity-2d

Merge lp://qastaging/~tiagosh/unity-2d/bugfix-891565 into lp://qastaging/unity-2d

  1. bugfix-891565
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp://qastaging/~tiagosh/unity-2d/bugfix-891565
Merge into: lp://qastaging/unity-2d
Diff against target: 108 lines (+74/-0)
2 files modified
places/LensBar.qml (+61/-0)
places/dash.qml (+13/-0)
To merge this branch: bzr merge lp://qastaging/~tiagosh/unity-2d/bugfix-891565
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
jenkins (community) continuous-integration Disapprove
Lohith D Shivamurthy (community) Needs Fixing
Review via email: mp+83154@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-11-22.

Description of the change

Implement lenses switching in dash by pressing CTRL+TAB, CTRL+SHIFT+TAB, CTRL+PGUP and CTRL+PGDOWN

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

Typos on lines 31 and 54 of the diff.

Also, please link to a bug from design, or assign one to ayatana-design, to get feedback on whether the navigation should wrap or not. In other instances, they explicitly said to disable wrapping, not sure it should be different here.

Revision history for this message
Gerry Boland (gerboland) wrote :

Until we get automated testing going, I need to ask you to write unit tests to test this fix, and place them in https://wiki.ubuntu.com/Unity2DRegressionTests

Please note that some may already be in https://wiki.ubuntu.com/UnityTests so you don't need to repeat them.

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Hey, Bug description says that TAB key should be supported. Would you add TAB key suport too? Please.

review: Needs Fixing
Revision history for this message
Gerry Boland (gerboland) wrote :

Hey Tiago,
I was keeping this MR aside as I found the code pretty huge for such a featurette. Now with the Home lens soon being an actual lens, it may simplify this a lit. So let's sit on this a little longer?
Thanks
-Gerry

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Yes, I believe it is better to wait for the home lens to be integrated. It will make things easier.
Besides that, this MR doesn't implement everything that was requested in that bug report.

Revision history for this message
Albert Astals Cid (aacid) wrote :

Doesn't apply cleanly to lp:unity-2d anymore

review: Needs Fixing
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:792
http://s-jenkins:8080/job/unity-2d-ci/10/

review: Disapprove (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:792
http://s-jenkins:8080/job/unity-2d-ci/25/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/unity-2d-ci/./distribution=precise,flavor=amd64/25/console
    FAILURE: http://s-jenkins:8080/job/unity-2d-ci/./distribution=precise,flavor=i386/25/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Cleaning up my review request queue[1], i guess noone cares if i reject this, right?

[1] https://code.launchpad.net/~aacid/+activereviews

review: Disapprove

Unmerged revisions

792. By Tiago Salem Herrmann

[places] cleanup legacy code

791. By Tiago Salem Herrmann

[places] move tab key handling code to dash.qml in order to make it work globally

790. By Tiago Salem Herrmann

[places] fix typo on comments

789. By Tiago Salem Herrmann

[places] add backtab handling for lenses switching

788. By Tiago Salem Herrmann

[places] make tab key switch between lenses

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches