Merge lp://qastaging/~tiagosh/unity-2d/fix-categories-divider into lp://qastaging/unity-2d

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 944
Merged at revision: 975
Proposed branch: lp://qastaging/~tiagosh/unity-2d/fix-categories-divider
Merge into: lp://qastaging/unity-2d
Diff against target: 135 lines (+43/-18)
3 files modified
shell/dash/CategoryHeader.qml (+16/-15)
shell/dash/Dash.qml (+0/-1)
shell/dash/LensView.qml (+27/-2)
To merge this branch: bzr merge lp://qastaging/~tiagosh/unity-2d/fix-categories-divider
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Albert Astals Cid (community) Approve
Xi Zhu (community) design Approve
Review via email: mp+94602@code.qastaging.launchpad.net

Description of the change

[dash] display category dividers instead of header underlines

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :
Revision history for this message
Xi Zhu (xi.zhu) wrote :

Hi, I had a looked at the the screenshots.

Here are some tweaks:

1.All category header should be 1px to the right.
2.The first category should be 3px down.
3.The 2nd & 3rd categories should be 2px down.
4.All dividers should be 15px away from each sides, so from the very left edge is: 64px(launcher)+1px(white line)+15px(gap) then its the start of divider.
5.Because all icons are sitting in a 64px invisible box, the bottom of the box to the bottom of divider is 64px (or you can say its 63px +1px line)
6.The top of icon title to the invisible box is 10px.

I attached the measurement file to the original bug link on the top, hope it would help.

And Thanks very much for all these work!

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Thanks Rosie,

some more changes: http://ubuntuone.com/0E8k4WA577UvEwiPlRDgIA

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :
Revision history for this message
Xi Zhu (xi.zhu) :
review: Approve (design)
Revision history for this message
Michał Sawicz (saviq) wrote :

You could possibly speed up the calculation by returning immediately when you find category == "0". There won't be any lower than that :)

review: Needs Fixing
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

good catch. just updated the branch.
Thanks.

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good, nice to have Design people having a look at the screenshots :-)

review: Approve
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/185/console reported an error when processing this lp:~tiagosh/unity-2d/fix-categories-divider branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/187/console reported an error when processing this lp:~tiagosh/unity-2d/fix-categories-divider branch.
Not merging it.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

now, the build environnement should install unity-common (for unity-2d only). Approving on behalf of the other approvals :)

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/189/console reported an error when processing this lp:~tiagosh/unity-2d/fix-categories-divider branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches