Plank

Merge lp://qastaging/~tigrangab/plank/focused_window_font into lp://qastaging/plank

focused_window_font
Merge into trunk

Proposed by Tigran Gabrielyan on 2013-12-17

Status:	Merged
Merged at revision:	951
Proposed branch:	lp://qastaging/~tigrangab/plank/focused_window_font
Merge into:	lp://qastaging/plank
Diff against target:	12 lines (+2/-0) 1 file modified lib/Items/ApplicationDockItem.vala (+2/-0)
To merge this branch:	bzr merge lp://qastaging/~tigrangab/plank/focused_window_font
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Rico Tzschichholz		Approve on 2014-01-23
Robert Dyer (community)	2013-12-17	Needs Information on 2013-12-17
Danielle Foré	2013-12-17	Pending
Review via email: mp+199349@code.qastaging.launchpad.net

Description of the change

When there are multiple windows opened of the same application, make the focused windows menu entry bold to know which one is focused.

Revision history for this message

Robert Dyer (psybers) wrote on 2013-12-17:

I wonder if maybe it makes more sense to just remove the entry from the list...

I'm not a fan of the menu items changing often (based on context). Perhaps we could leave it and make it disabled?

Again, I'm asking for input from Dan here.

review: Needs Information

Revision history for this message

Tigran Gabrielyan (tigrangab) wrote on 2013-12-17:

The change for that is trivial, so just let me know the design choice, and I will fix it.

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2014-01-04:

I like it as it looks now. Hiding items for actual visible windows is not a good idea.

Two notes:
* I would only add the focus action for non-active windows.
* explicit use of copy "var font_description = window_item.get_pango_context ().get_font_description ().copy ();"

Revision history for this message

Danielle Foré (danrabbit) wrote on 2014-01-20:

I agree with Robert that insensitive makes more sense than bold.

In the case of switching windows, I think you're precisely not looking for the active window. So making it stand out by making it bold I think draws your attention in the opposite of the desired direction.

I also agree with Rico that removing the item doesn't sound right.

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2014-01-21:

OK, making them only insensitive seems fine then.

review: Needs Fixing

lp://qastaging/~tigrangab/plank/focused_window_font updated on 2014-01-21