Merge lp://qastaging/~timchen119/notify-osd/notify-osd.lp404658 into lp://qastaging/notify-osd

Proposed by Tim Chen
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~timchen119/notify-osd/notify-osd.lp404658
Merge into: lp://qastaging/notify-osd
Diff against target: 79 lines (+33/-21)
2 files modified
debian/changelog (+10/-0)
src/stack.c (+23/-21)
To merge this branch: bzr merge lp://qastaging/~timchen119/notify-osd/notify-osd.lp404658
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ubuntu Sponsors Pending
Review via email: mp+192467@code.qastaging.launchpad.net

Commit message

Provide the "x-canonical-private-synchronous" to work with notifications different with LAYOUT_ICON_INDICATOR layout.
  Currently the "x-canonical-private-synchronous" interface only provide this layout to support brightness and volume control.

  This make following command behave correctly.
  $notify-send "RF-status" "enabled" -h string:x-canonical-private-synchronous:1 -h string:image_path:/tmp/test.jpg

  Canonical OEM projects need this function to

  * enable OSD for enable/disable WiFi or bluetooth with a hotkey
  * enable OSD for display switching with a hotkey
(LP: #404658)

Description of the change

  Provide the "x-canonical-private-synchronous" to work with notifications different with LAYOUT_ICON_INDICATOR layout.
  Currently the "x-canonical-private-synchronous" interface only provide this layout to support brightness and volume control.

  This make following command behave correctly.
  $notify-send "RF-status" "enabled" -h string:x-canonical-private-synchronous:1 -h string:image_path:/tmp/test.jpg

  Canonical OEM projects need this function to

  * enable OSD for enable/disable WiFi or bluetooth with a hotkey
  * enable OSD for display switching with a hotkey

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:472
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~timchen119/notify-osd/notify-osd.lp404658/+merge/192467/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/notify-osd-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-trusty-i386-ci/1

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notify-osd-ci/5/rebuild

review: Needs Fixing (continuous-integration)
473. By Tim Chen

* Add changelog.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Thanks for this patch, but it doesn't fully fix bug #404658. The summary and body of a synchronous notification are not updated when a new synchronous notification is sent.

This patch also changes whitespace around the changed lines.

I've incorporated your patch in lp:~~larsu/notify-osd/update-sync.

Unmerged revisions

473. By Tim Chen

* Add changelog.

472. By Tim Chen

Provide the "x-canonical-private-synchronous" to work with notifications different with LAYOUT_ICON_INDICATOR layout.
Currently the "x-canonical-private-synchronous" interface only provide this layout to support brightness and volume control.

This make following command behave correctly.
$notify-send "RF-status" "enabled" -h string:x-canonical-private-synchronous:1 -h string:image_path:/tmp/test.jpg

Canonical OEM projects need this function to

* enable OSD for enable/disable WiFi or bluetooth with a hotkey
* enable OSD for display switching with a hotkey

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches