Merge lp://qastaging/~timchen119/notify-osd/notify-osd.precise.lp404658 into lp://qastaging/ubuntu/precise/notify-osd

Proposed by Tim Chen
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~timchen119/notify-osd/notify-osd.precise.lp404658
Merge into: lp://qastaging/ubuntu/precise/notify-osd
Diff against target: 79 lines (+33/-21)
2 files modified
debian/changelog (+10/-0)
src/stack.c (+23/-21)
To merge this branch: bzr merge lp://qastaging/~timchen119/notify-osd/notify-osd.precise.lp404658
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+192468@code.qastaging.launchpad.net

Description of the change

Provide the "x-canonical-private-synchronous" to work with notifications different with LAYOUT_ICON_INDICATOR layout.
Currently the "x-canonical-private-synchronous" interface only provide this layout to support brightness and volume control.

This make following command behave correctly.
$notify-send "RF-status" "enabled" -h string:x-canonical-private-synchronous:1 -h string:image_path:/tmp/test.jpg

Canonical OEM projects need this function to

* enable OSD for enable/disable WiFi or bluetooth with a hotkey
* enable OSD for display switching with a hotkey

To post a comment you must log in.
63. By Tim Chen

* Add changelog

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for the work, settings as rejected for the same reason than https://code.launchpad.net/~timchen119/notify-osd/notify-osd.lp404658/+merge/192467

Unmerged revisions

63. By Tim Chen

* Add changelog

62. By Tim Chen

  Provide the "x-canonical-private-synchronous" to work with notifications different with LAYOUT_ICON_INDICATOR layout.
  Currently the "x-canonical-private-synchronous" interface only provide this layout to support brightness and volume control.

  This make following command behave correctly.
  $notify-send "RF-status" "enabled" -h string:x-canonical-private-synchronous:1 -h string:image_path:/tmp/test.jpg

  Canonical OEM projects need this function to

  * enable OSD for enable/disable WiFi or bluetooth with a hotkey
  * enable OSD for display switching with a hotkey

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: