Compiz Core

Merge lp://qastaging/~timo-jyrinki/compiz-core/revert_bzr3111 into lp://qastaging/compiz-core

  1. revert_bzr3111
  2. Merge into 0.9.7
Proposed by Timo Jyrinki
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 3123
Merged at revision: 3123
Proposed branch: lp://qastaging/~timo-jyrinki/compiz-core/revert_bzr3111
Merge into: lp://qastaging/compiz-core
Diff against target: 32 lines (+9/-10)
1 file modified
scripts/run-with-xvfb.sh (+9/-10)
To merge this branch: bzr merge lp://qastaging/~timo-jyrinki/compiz-core/revert_bzr3111
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+134055@code.qastaging.launchpad.net

Commit message

Revert bzr3111, non-SRU patch and not very useful

Description of the change

Revert bzr3111, non-SRU patch and not very useful

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

20121113|11:16 < Mirv> didrocks: wasn't it so that you rejected
http://bazaar.launchpad.net/~compiz-team/compiz-core/0.9.7/revision/3111 from
                       precise SRU in the summer, and thus it should be
                       reverted in the 0.9.7 branch as well?
20121113|11:16 < Mirv> I'm not sure if I remember right
20121113|11:17 < Mirv> it's not very useful patch anyway for SRU
20121113|11:17 < didrocks> Mirv: yeah, it's not really useful, if it's not in
                           precise, you should revert it

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Yea, agreed +1

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It makes me sad we have to revert fixes that make development and testing easier :(

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

To be fair, the tests shouldn't require a running xserver. The only
ones that should are in lp:compiz and they depend on xorg-gtest

On Tue, Nov 13, 2012 at 5:54 PM, Daniel van Vugt
<email address hidden> wrote:
> It makes me sad we have to revert fixes that make development and testing easier :(
> --
> https://code.launchpad.net/~timo-jyrinki/compiz-core/revert_bzr3111/+merge/134055
> Your team Compiz Maintainers is subscribed to branch lp:compiz-core.

--
Sam Spilsbury

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches