Merge lp://qastaging/~timo-jyrinki/dropping-letters/drop_audiorole_usage into lp://qastaging/dropping-letters

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 69
Merged at revision: 69
Proposed branch: lp://qastaging/~timo-jyrinki/dropping-letters/drop_audiorole_usage
Merge into: lp://qastaging/dropping-letters
Diff against target: 33 lines (+0/-4)
1 file modified
dropping-letters.qml (+0/-4)
To merge this branch: bzr merge lp://qastaging/~timo-jyrinki/dropping-letters/drop_audiorole_usage
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Jim Hodapp (community) code Approve
Dropping Letters developers Pending
Review via email: mp+275150@code.qastaging.launchpad.net

Commit message

Drop audioRole usage as it shouldn't be used in this use case

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good to me.

review: Approve (code)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/dropping-letters-autolanding/1/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/379/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches