qtubuntu-media

Merge lp://qastaging/~timo-jyrinki/qtubuntu-media/port_to_new_audio_role_api into lp://qastaging/qtubuntu-media

  1. port_to_new_audio_role_api
  2. Merge into trunk
Proposed by Timo Jyrinki
Status: Merged
Approved by: Jim Hodapp
Approved revision: 91
Merged at revision: 91
Proposed branch: lp://qastaging/~timo-jyrinki/qtubuntu-media/port_to_new_audio_role_api
Merge into: lp://qastaging/qtubuntu-media
Diff against target: 118 lines (+42/-0)
4 files modified
src/aal/aalmediaplayercontrol.cpp (+8/-0)
src/aal/aalmediaplayercontrol.h (+5/-0)
src/aal/aalmediaplayerservice.cpp (+24/-0)
src/aal/aalmediaplayerservice.h (+5/-0)
To merge this branch: bzr merge lp://qastaging/~timo-jyrinki/qtubuntu-media/port_to_new_audio_role_api
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+273392@code.qastaging.launchpad.net

Commit message

Port to the new Audio Role API (LP: #1493851)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:87
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/129/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/54/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/54/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/54/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/129/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/130/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/55/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/55/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/55/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/130/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/131/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/56/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/56/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/56/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/131/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/132/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/57/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/132/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
Revision history for this message
Jim Hodapp (jhodapp) :
review: Needs Information (code)
Revision history for this message
Jim Hodapp (jhodapp) :
lp://qastaging/~timo-jyrinki/qtubuntu-media/port_to_new_audio_role_api updated
91. By Timo Jyrinki

add || for MusicRole as suggested in the comment

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok added the MusicRole to the latter one and answered to the first question. Note that I'm not familiar with the whole chain (Android/PulseAudio/Qt) so I don't know as such the correct selections necessarily.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:91
http://jenkins.qa.ubuntu.com/job/qtubuntu-media-ci/133/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-amd64-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-armhf-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-media-vivid-i386-ci/58/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-media-ci/133/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good. One reminder. Before this will function correctly we need to update at least media-hub but I'm also thinking we need to update pulseaudio as it is the layer that gives meaning to these various roles and this new list is completely different.

review: Approve (code)
lp://qastaging/~timo-jyrinki/qtubuntu-media/port_to_new_audio_role_api updated
92. By Timo Jyrinki

Fix invalid non-breaking space character :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches