Files

Merge lp://qastaging/~tintou/pantheon-files/file-chooser-no-static into lp://qastaging/~elementary-apps/pantheon-files/trunk

  1. file-chooser-no-static
  2. Merge into trunk
Proposed by Corentin Noël
Status: Merged
Approved by: Danielle Foré
Approved revision: 2575
Merged at revision: 2575
Proposed branch: lp://qastaging/~tintou/pantheon-files/file-chooser-no-static
Merge into: lp://qastaging/~elementary-apps/pantheon-files/trunk
Diff against target: 45 lines (+8/-8)
2 files modified
filechooser-module/FileChooserDialog.vala (+6/-6)
filechooser-module/Plugin.vala (+2/-2)
To merge this branch: bzr merge lp://qastaging/~tintou/pantheon-files/file-chooser-no-static
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Adam Bieńkowski (community) code / testing Approve
Review via email: mp+325261@code.qastaging.launchpad.net

Commit message

* Don't use static fields when it depends on the class, use unowned variables when needed

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Great, fixes the issue, thanks.

review: Approve (code / testing)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Can confirm, does the thing :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: