Photos

Merge lp://qastaging/~tintou/pantheon-photos/grid-css into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. grid-css
  2. Merge into trunk
Proposed by Corentin Noël
Status: Merged
Approved by: Danielle Foré
Approved revision: 3134
Merged at revision: 3135
Proposed branch: lp://qastaging/~tintou/pantheon-photos/grid-css
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 885 lines (+133/-455)
8 files modified
src/CheckerboardLayout.vala (+114/-264)
src/MediaPage.vala (+0/-4)
src/Thumbnail.vala (+13/-4)
src/config/Config.vala (+0/-88)
src/config/ConfigurationInterfaces.vala (+0/-31)
src/config/GSettingsEngine.vala (+0/-1)
src/events/EventDirectoryItem.vala (+6/-27)
src/util/image.vala (+0/-36)
To merge this branch: bzr merge lp://qastaging/~tintou/pantheon-photos/grid-css
Reviewer Review Type Date Requested Status
Photos Devs Pending
Review via email: mp+315732@code.qastaging.launchpad.net

Commit message

Replace Cairo drawing in CheckBoardLayout with Gtk.CSS

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

This is great! Just a couple more things:

There's a whole bunch of constants we can get rid of in src/config/Config.vala from lines 45 to 53.

There are two unused methods
* draw_rounded_corners_filled in image.vala:65.1-65.32
* CheckerboardItem.get_selection_border_width in CheckerboardLayout.vala:454.5-454.42

Revision history for this message
Danielle Foré (danrabbit) wrote :

Oops, looks like you already did a new commit to remove those methods, my bad

Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm going to make another branch about the constants. Looks like there's some unused ones maybe not related to this branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: