Photos

Merge lp://qastaging/~tintou/pantheon-photos/menu-to-vala into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. menu-to-vala
  2. Merge into trunk
Proposed by Corentin Noël
Status: Merged
Approved by: Danielle Foré
Approved revision: 3151
Merged at revision: 3157
Proposed branch: lp://qastaging/~tintou/pantheon-photos/menu-to-vala
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 2248 lines (+1012/-649)
32 files modified
data/ui/collection.ui (+0/-44)
data/ui/direct.ui (+0/-7)
data/ui/direct_context.ui (+0/-11)
data/ui/event.ui (+0/-12)
data/ui/events_directory.ui (+0/-24)
data/ui/import.ui (+0/-22)
data/ui/media.ui (+0/-27)
data/ui/offline.ui (+0/-23)
data/ui/photo.ui (+0/-27)
data/ui/photo_context.ui (+0/-31)
data/ui/savedsearch.ui (+0/-8)
data/ui/search_sidebar_context.ui (+0/-6)
data/ui/sidebar_default_context.ui (+0/-7)
data/ui/tag_sidebar_context.ui (+0/-6)
data/ui/tags.ui (+0/-16)
data/ui/trash.ui (+0/-28)
src/CollectionPage.vala (+222/-88)
src/MediaPage.vala (+126/-21)
src/Page.vala (+3/-40)
src/PhotoPage.vala (+136/-34)
src/camera/ImportPage.vala (+97/-10)
src/direct/DirectPhotoPage.vala (+48/-33)
src/direct/DirectWindow.vala (+1/-1)
src/events/EventPage.vala (+15/-10)
src/events/EventsDirectoryPage.vala (+83/-7)
src/library/OfflinePage.vala (+90/-8)
src/library/TrashPage.vala (+105/-8)
src/searches/Branch.vala (+9/-25)
src/searches/SavedSearchPage.vala (+26/-7)
src/sidebar/Tree.vala (+14/-28)
src/tags/Branch.vala (+9/-25)
src/tags/TagPage.vala (+28/-5)
To merge this branch: bzr merge lp://qastaging/~tintou/pantheon-photos/menu-to-vala
Reviewer Review Type Date Requested Status
Danielle Foré Needs Fixing
Review via email: mp+316393@code.qastaging.launchpad.net

Commit message

Move all the context menus to Vala

Description of the change

I hope this is close to a 1:1 conversion.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

Note: The next step is to move from Gtk.Action to GLib.Action

Revision history for this message
Danielle Foré (danrabbit) wrote :

Okay after some testing I found:

* Toggling the places or metadata sidebar from two different views will cause photos to crash
* Fullscreen is a missing option in the main photos view
* I can't seem to figure out how to reliably reproduce this but sometimes when a menu closes the view sorting is reverted

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

Oops I was wrong on the last one. Happens when the menu opens. So I guess that metadata_action.activate must get triggered when the menu is loaded maybe?

Revision history for this message
Danielle Foré (danrabbit) wrote :

"Empty Trash" from the trash context menu item seems to not do anything

Revision history for this message
Danielle Foré (danrabbit) wrote :

Not sure if this helps diagnose, but after using the menu to hide/reveal the sidebar, trying to do so with the button in the toolbar crashes Photos

Revision history for this message
Danielle Foré (danrabbit) wrote :

In the library view, the slideshow button appears at the end of the toolbar, but in the single photo view it appears at the beginning.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Rotate, flip, and publish are sensitive in the library view when nothing is selected. Auto-adjust seems to be working properly

Revision history for this message
Corentin Noël (tintou) wrote :

I've applied the requested changes

Revision history for this message
Danielle Foré (danrabbit) wrote :

Right on! I can confirm that a number of the issues are fixed. But I found more ;p

* In Fullscreen, there is an empty context menu

* Sorting photos doesn't seem to work at all anymore :p

* Empty Trash in the places sidebar context menu still doesn't seem to do anything

* The "Show Info Panel" button in the toolbar doesn't always seem to update its icon state correctly. To reproduce:
    1. hide the panel (from the context menu)
    2. switch views
    3. reveal the panel (from the context menu)
    4. Switch back to the original view

lp://qastaging/~tintou/pantheon-photos/menu-to-vala updated
3151. By Corentin Noël

Moved all the context menus to Vala

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: