Scratch

Merge lp://qastaging/~tintou/scratch/filemanager into lp://qastaging/~elementary-apps/scratch/scratch

filemanager
Merge into scratch

Proposed by Corentin Noël on 2016-09-03

Status:	Rejected
Rejected by:	Zisu Andrei on 2016-11-18
Proposed branch:	lp://qastaging/~tintou/scratch/filemanager
Merge into:	lp://qastaging/~elementary-apps/scratch/scratch
Diff against target:	1566 lines (+330/-994) 19 files modified plugins/CMakeLists.txt (+0/-1) plugins/filemanager/CMakeLists.txt (+2/-0) plugins/filemanager/File.vala (+3/-3) plugins/filemanager/FileItem.vala (+52/-0) plugins/filemanager/FileManagerPlugin.vala (+68/-46) plugins/filemanager/FileView.vala (+39/-210) plugins/filemanager/FolderItem.vala (+154/-0) plugins/filemanager/Settings.vala (+1/-1) plugins/folder-manager/CMakeLists.txt (+0/-29) plugins/folder-manager/File.vala (+0/-207) plugins/folder-manager/FileView.vala (+0/-312) plugins/folder-manager/FolderManagerPlugin.vala (+0/-122) plugins/folder-manager/Settings.vala (+0/-36) plugins/folder-manager/folder-manager.plugin (+0/-10) plugins/outline/OutlinePlugin.vala (+4/-1) plugins/source-tree/SourceTreePlugin.vala (+3/-1) schemas/CMakeLists.txt (+0/-1) schemas/org.pantheon.scratch.plugins.file-manager.gschema.xml (+4/-4) schemas/org.pantheon.scratch.plugins.folder-manager.gschema.xml (+0/-10)
To merge this branch:	bzr merge lp://qastaging/~tintou/scratch/filemanager
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Danielle Foré	ux		Needs Fixing on 2016-09-03
Zisu Andrei (community)		2016-09-03	Needs Fixing on 2016-09-03
Review via email: mp+304845@code.qastaging.launchpad.net

lp://qastaging/~tintou/scratch/filemanager updated on 2016-09-03

1748. By Corentin Noël on 2016-09-03: Fix CMake warnings in the plugins

Revision history for this message

Zisu Andrei (matzipan) wrote on 2016-09-03:

This branch works as advertised, but, as discussed, we need to change the root item into a folder item too so you can use the context menu to add files to it, instead of using the plus sign at the bottom.

Also maybe after creating a new file, the sidebar entry needs to be opened in rename mode so that the user can type in the desired name.

review: Needs Fixing

Revision history for this message

Corentin Noël (tintou) wrote on 2016-09-03:

Aaand it's ready for a new review.

Revision history for this message

Danielle Foré (danrabbit) wrote on 2016-09-03:

Hm, unsure what the intended behavior is here. After installing this branch, the File Manager plugin appears to be completely empty and do nothing. I don't notice any changes to the Folder Manager plugin.

Revision history for this message

Danielle Foré (danrabbit) wrote on 2016-09-03:

This is definitely needs fixing on UX:

* It seems like you can only add one folder at a time. I really think the button to add a folder in the headerbar needs to come back. It's simple and obvious.

* Having this welcome screen in the sidebar is really bad. Especially if you don't have a file open you can have two welcome screens side-by-side. This is a pretty big annoyance from the previous behavior where it was possible to not have any folders open. This new behavior requires turning the plugin on and off. It's really annoying.

review: Needs Fixing (ux)

lp://qastaging/~tintou/scratch/filemanager updated on 2016-09-03

1749. By Corentin Noël on 2016-09-03: Unified the file manager and folder manager.

Revision history for this message

Danielle Foré (danrabbit) wrote on 2016-11-18:

This is way better than it was before.

One thing I still don't like is the open folder button disappearing from the headerbar. I don't like the actions moving around like this. It means that once I perform the action I now have to go hunt to figure out how to perform that action again. The UI is not predictable.

Revision history for this message

Zisu Andrei (matzipan) wrote on 2016-11-18:

Rejected because I branched and wrapped up the changes here: https://code.launchpad.net/~matzipan/scratch/filemanager/+merge/311301