Merge lp://qastaging/~tintou/slingshot/gtk-popover into lp://qastaging/~elementary-pantheon/slingshot/trunk
Proposed by
Corentin Noël
| Status: | Merged | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Danielle Foré | ||||||||||||||||
| Approved revision: | 505 | ||||||||||||||||
| Merged at revision: | 500 | ||||||||||||||||
| Proposed branch: | lp://qastaging/~tintou/slingshot/gtk-popover | ||||||||||||||||
| Merge into: | lp://qastaging/~elementary-pantheon/slingshot/trunk | ||||||||||||||||
| Diff against target: |
1152 lines (+196/-392) 11 files modified
CMakeLists.txt (+1/-2) cmake/ValaPrecompile.cmake (+0/-1) src/Pixels.vala (+2/-2) src/Slingshot.vala (+1/-2) src/SlingshotView.vala (+142/-104) src/Widgets/AppEntry.vala (+22/-28) src/Widgets/CategoryView.vala (+2/-4) src/Widgets/Grid.vala (+18/-20) src/Widgets/PopoverMenu.vala (+0/-188) src/Widgets/SearchItem.vala (+2/-2) src/Widgets/SearchView.vala (+6/-39) |
||||||||||||||||
| To merge this branch: | bzr merge lp://qastaging/~tintou/slingshot/gtk-popover | ||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Make use of Gtk.Popover instead of Granite.Popover.
Animates the view change from the edges.
Use real size of App Buttons (removed useless and wrong code)
Description of the change
Make use of Gtk.Popover instead of Granite.Popover.
Animates the view change from the edges.
Use real size of App Buttons (removed useless and wrong code)
To post a comment you must log in.
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Revision history for this message
| Cody Garver (codygarver) wrote | # |
Revision history for this message
| Corentin Noël (tintou) wrote | # |
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This seems to be quite an improvement overall. Gaining regular right click menus and also the cut/copy/paste/etc menu is killer.
I love that the animations go to the edge of the popover. Very sexy!
Something that is annoying is that it seems to animate from the bottom up. I see this as a regression. Ideally it would animate from the origin towards the opposite corner of the display. But at least the current version animates from the center out.
It does seem that this makes Slingshot shorter, which is a bit weird at first, but I think it'll be easy to get used to. I wouldn't really consider this a regression.
When navigating by keyboard, I noticed that moving from the 2nd-to-last to the last page, you can lose the selection if you go from the 2nd (or 3rd) row and there is only 1 row on the last page.
The scrolled window in the search view should have a right margin. Unfortunately because of the rounded corners, it seems to hang off of the bottom right corner of the popover.
There is also a small jump where the popover resizes between grid and search views