Merge lp://qastaging/~tintou/switchboard-plug-useraccounts/avatar-no-pixbuf into lp://qastaging/~elementary-pantheon/switchboard-plug-useraccounts/trunk

Proposed by Corentin Noël
Status: Needs review
Proposed branch: lp://qastaging/~tintou/switchboard-plug-useraccounts/avatar-no-pixbuf
Merge into: lp://qastaging/~elementary-pantheon/switchboard-plug-useraccounts/trunk
Diff against target: 20 lines (+4/-6)
1 file modified
src/Widgets/UserItem.vala (+4/-6)
To merge this branch: bzr merge lp://qastaging/~tintou/switchboard-plug-useraccounts/avatar-no-pixbuf
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Needs Information
Review via email: mp+313496@code.qastaging.launchpad.net

Description of the change

Don't use pixbufs

To post a comment you must log in.
264. By Corentin Noël

Use the image files directly

Revision history for this message
Zisu Andrei (matzipan) wrote :

1 comment inline

review: Needs Information
Revision history for this message
Corentin Noël (tintou) wrote :

widget.destroy () != delete (widget)
https://valadoc.org/gtk+-3.0/Gtk.Widget.destroy.html
It just kindly ask its container to release it, which results in freeing it.
But you're right for the null-check

Unmerged revisions

264. By Corentin Noël

Use the image files directly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: