Ubuntu
sudo package

Merge lp://qastaging/~tj/ubuntu/precise/sudo/lp927828 into lp://qastaging/ubuntu/precise/sudo

  1. Precise (12.04)
  2. lp927828
  3. Merge into precise
Proposed by TJ
Status: Merged
Merge reported by: Colin Watson
Merged at revision: not available
Proposed branch: lp://qastaging/~tj/ubuntu/precise/sudo/lp927828
Merge into: lp://qastaging/ubuntu/precise/sudo
Diff against target: 128 lines (+108/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/lp927828-fix-abort-in-pam-modules-when-timestamp-valid.patch (+101/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~tj/ubuntu/precise/sudo/lp927828
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+102975@code.qastaging.launchpad.net

Description of the change

This fixes LP: #927828 "sudo: pam_mount.c:417: modify_pm_count: Assertion `user != ((void *)0)' failed."

When the sudo timestamp is valid there is an Abort in pam_mount because sudo did not call pam_open_session() before forking.

After analysing the issue (see the bug report) I reported it upstream where a patch was developed against the current development tree.

http://www.gratisoft.us/bugzilla/show_bug.cgi?id=553

After testing that patch locally to ensure it works I have back-ported it and tested on precise's 1.8.3p1. The abort no longer occurs. gdb breakpoints confirm pam_open_session() is now called correctly.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

"Origin: backported-from-upstream" - http://dep.debian.net/deps/dep3/ says that should be "backport".

Otherwise this looks reasonable, thanks. I'll upload it to quantal and precise-proposed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches