Merge lp://qastaging/~tomasgroth/openlp/25bugfixes1 into lp://qastaging/openlp

Proposed by Tomas Groth
Status: Merged
Approved by: Tomas Groth
Approved revision: 2631
Merged at revision: 2628
Proposed branch: lp://qastaging/~tomasgroth/openlp/25bugfixes1
Merge into: lp://qastaging/openlp
Diff against target: 239 lines (+76/-44)
7 files modified
openlp/core/ui/exceptionform.py (+6/-4)
openlp/plugins/custom/forms/editcustomform.py (+1/-0)
openlp/plugins/songs/lib/importers/easyworship.py (+40/-32)
openlp/plugins/songs/lib/mediaitem.py (+2/-2)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+2/-2)
tests/interfaces/openlp_core_lib/test_pluginmanager.py (+9/-4)
tests/interfaces/openlp_plugins/custom/forms/test_customform.py (+16/-0)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/25bugfixes1
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Approve
Review via email: mp+288872@code.qastaging.launchpad.net

Description of the change

Fix slide order change when splitting custom slides. Fixes bug 1554748.
Fix EasyWorship import issues with missing verses and traceback on unknown chars.
Fix traceback in the bug-report dialog. Fixes bug 1554428.
Fix weird test bug in test_pluginmanager.py.
Pep8 fixes

To post a comment you must log in.
Revision history for this message
Tomas Groth (tomasgroth) wrote :
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Looks good to me.

review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.