OpenLP

Merge lp://qastaging/~tomasgroth/openlp/chordpro-fixes into lp://qastaging/openlp

  1. chordpro-fixes
  2. Merge into trunk
Proposed by Tomas Groth
Status: Superseded
Proposed branch: lp://qastaging/~tomasgroth/openlp/chordpro-fixes
Merge into: lp://qastaging/openlp
Diff against target: 90 lines (+38/-0)
3 files modified
openlp/plugins/songs/lib/importers/chordpro.py (+32/-0)
tests/resources/songs/chordpro/swing-low.chordpro (+2/-0)
tests/resources/songs/chordpro/swing-low.json (+4/-0)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/chordpro-fixes
Reviewer Review Type Date Requested Status
Raoul Snyman Needs Fixing
Tim Bentley Pending
Review via email: mp+371955@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-08-28.

This proposal has been superseded by a proposal from 2019-08-29.

Commit message

Added support for more directives/tags when importing chord pro files.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/14/ for more details

Revision history for this message
Tim Bentley (trb143) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

JavaScript tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Minor issue.

review: Needs Fixing
lp://qastaging/~tomasgroth/openlp/chordpro-fixes updated
2896. By Tomas Groth

Added artist as a supported directive.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.