Merge lp://qastaging/~tomasgroth/openlp/fix-theme-thumb into lp://qastaging/openlp
Proposed by
Tomas Groth
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~tomasgroth/openlp/fix-theme-thumb |
| Merge into: | lp://qastaging/openlp |
| Diff against target: |
519 lines (+145/-98) 8 files modified
openlp/core/display/render.py (+70/-27) openlp/core/ui/media/vlcplayer.py (+14/-13) openlp/core/ui/themeform.py (+20/-15) openlp/core/ui/thememanager.py (+12/-14) openlp/core/ui/themewizard.py (+9/-10) openlp/plugins/media/lib/mediaitem.py (+10/-9) openlp/plugins/songs/lib/songstab.py (+1/-1) tests/functional/openlp_core/ui/test_thememanager.py (+9/-9) |
| To merge this branch: | bzr merge lp://qastaging/~tomasgroth/openlp/fix-theme-thumb |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raoul Snyman | Needs Fixing | ||
| Tim Bentley | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2019-06-07.
Commit message
Add a webengine view for previewing themes.
Made VLC loading more robust.
A few minor fixes.
To post a comment you must log in.
Revision history for this message
| Raoul Snyman (raoul-snyman) wrote | # |
Revision history for this message
| Tim Bentley (trb143) | # |
review:
Approve
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Linux tests failed, please see https:/