OpenLP

Merge lp://qastaging/~tomasgroth/openlp/portable-path into lp://qastaging/openlp

  1. portable-path
  2. Merge into trunk
Proposed by Tomas Groth
Status: Merged
Merged at revision: 2863
Proposed branch: lp://qastaging/~tomasgroth/openlp/portable-path
Merge into: lp://qastaging/openlp
Diff against target: 87 lines (+36/-2)
2 files modified
openlp/core/app.py (+13/-2)
tests/functional/openlp_core/test_app.py (+23/-0)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/portable-path
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Phill Approve
Review via email: mp+366785@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-04-30.

Commit message

Make it possible to specify the portable path to use for OpenLP Data when in portable mode. This is very useful during development.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/134/ for more details

Revision history for this message
Phill (phill-ridout) wrote : Posted in a previous version of this proposal

Sorry, a few nit picks...

review: Needs Fixing
Revision history for this message
Phill (phill-ridout) wrote : Posted in a previous version of this proposal

Also tests failed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Phill (phill-ridout) wrote :

Thanks

review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.