OpenLP

Merge lp://qastaging/~tomasgroth/openlp/presentation-beyond-last into lp://qastaging/openlp

  1. presentation-beyond-last
  2. Merge into trunk
Proposed by Tomas Groth
Status: Superseded
Proposed branch: lp://qastaging/~tomasgroth/openlp/presentation-beyond-last
Merge into: lp://qastaging/openlp
Diff against target: 646 lines (+269/-55)
7 files modified
openlp/core/common/registry.py (+1/-1)
openlp/core/ui/servicemanager.py (+6/-0)
openlp/core/ui/slidecontroller.py (+22/-6)
openlp/plugins/presentations/lib/impresscontroller.py (+192/-21)
openlp/plugins/presentations/lib/messagelistener.py (+20/-20)
openlp/plugins/presentations/lib/powerpointcontroller.py (+23/-4)
openlp/plugins/presentations/lib/presentationcontroller.py (+5/-3)
To merge this branch: bzr merge lp://qastaging/~tomasgroth/openlp/presentation-beyond-last
Reviewer Review Type Date Requested Status
OpenLP Core Pending
Review via email: mp+367921@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-05-23.

This proposal has been superseded by a proposal from 2019-05-25.

Commit message

Make it possible to go to next or previous service item when stepping through a presentation.
Disables impress and powerpoint presentation console.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/158/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/103/ for more details

Revision history for this message
Phill (phill-ridout) wrote : Posted in a previous version of this proposal

Whats happrning with the commented out code?

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/107/ for more details

lp://qastaging/~tomasgroth/openlp/presentation-beyond-last updated
2672. By Tomas Groth

Remove unused code

2673. By Tomas Groth

Fix traceback on Mac tests

2674. By Tomas Groth

pep8

2675. By Tomas Groth

trunk

2676. By Tomas Groth

Fix as suggested

2677. By Tomas Groth

merge trunk

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.