Compiz

Merge lp://qastaging/~townsend/compiz/fix-minimize-unredirect-window-0.9.9 into lp://qastaging/compiz/0.9.9

  1. fix-minimize-unredirect-window-0.9.9
  2. Merge into 0.9.9
Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3654
Merged at revision: 3654
Proposed branch: lp://qastaging/~townsend/compiz/fix-minimize-unredirect-window-0.9.9
Merge into: lp://qastaging/compiz/0.9.9
Diff against target: 71 lines (+27/-2)
4 files modified
plugins/opengl/src/fsregion/fsregion.cpp (+1/-1)
plugins/opengl/src/fsregion/fsregion.h (+2/-1)
plugins/opengl/src/fsregion/tests/test-fsregion.cpp (+19/-0)
plugins/opengl/src/paint.cpp (+5/-0)
To merge this branch: bzr merge lp://qastaging/~townsend/compiz/fix-minimize-unredirect-window-0.9.9
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+163162@code.qastaging.launchpad.net

Commit message

Fixed issue where minimizing an unredirect full screen window would repaint the full screen window after minimizing it even though it isn't really there. This is a backport of lp:compiz revno. 3686.

Description of the change

Note: This is a backport of lp:compiz revno. 3686.

= Issue =
Minimizing an unredirect full screen window will display the full screen window after the minimization even though it isn't really there.

= Fix =
Do not unredirect a full screen window if no occlusion is detected meaning that it has been minimized.

= Test =
Added some unit test coverage with Sam's guidance.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3654
http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-armhf-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-0.9.9-raring-i386-ci/4
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/210/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-0.9.9-ci/4/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I've filed bug https://bugs.launchpad.net/compiz/+bug/1178514 about the failing tests. Its not an issue here specifically.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches