Unity

Merge lp://qastaging/~townsend/unity/fix-lp1064155 into lp://qastaging/unity

  1. fix-lp1064155
  2. Merge into trunk
Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3320
Proposed branch: lp://qastaging/~townsend/unity/fix-lp1064155
Merge into: lp://qastaging/unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/src/unityshell.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~townsend/unity/fix-lp1064155
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury (community) Approve
Review via email: mp+162271@code.qastaging.launchpad.net

Commit message

Fixes issue where minimizing a full screen window would not draw the Launcher and Panel after minimization.

Description of the change

= Issue =
Upon minimizing a full screen window, the Launcher and Panel are not visible.

= Fix =
Add logic to check if full screen windows are minimized.

= Test =
This is a visual issue. Reproduce issue by minimizing a full screen window and observe Launcher and Panel is not visible. Apply this merge and observe that minimizing a full screen window will display the Launcher and Panel.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3316
http://jenkins.qa.ubuntu.com/job/unity-ci/46/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/46/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Like the compiz merge proposal, I feel like this is probably in the wrong place. The correct approach would be to not add the minimized window to fullscreen_windows_ in the first place in UnityWindow::glPaint rather than checking for a minimized fullscreen window in fullscren_windows_ later and preventing the operation of the occlusion code after that.

Revision history for this message
Christopher Townsend (townsend) wrote :

Thanks Sam. I will re-work this some to take your suggestions into account.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Great, looks good to me :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3317
http://jenkins.qa.ubuntu.com/job/unity-ci/49/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-ci/49

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/49/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.