Merge lp://qastaging/~townsend/unity/no-window-decorations-5.0 into lp://qastaging/unity/5.0

Proposed by Christopher Townsend
Status: Merged
Approved by: Martin Mrazik
Approved revision: no longer in the source branch.
Merged at revision: 2415
Proposed branch: lp://qastaging/~townsend/unity/no-window-decorations-5.0
Merge into: lp://qastaging/unity/5.0
Diff against target: 318 lines (+106/-34)
5 files modified
plugins/unityshell/src/PanelMenuView.cpp (+3/-3)
plugins/unityshell/src/PluginAdapter.cpp (+91/-29)
plugins/unityshell/src/PluginAdapter.h (+6/-2)
plugins/unityshell/src/WindowManager.cpp (+5/-0)
plugins/unityshell/src/WindowManager.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~townsend/unity/no-window-decorations-5.0
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Brandon Schaefer (community) Approve
Review via email: mp+154970@code.qastaging.launchpad.net

Commit message

Partial backport of Unity trunk revno. 2901 to fix where window decorations are being drawn when they should not be.

Description of the change

This is partial backport of http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/2901 and fixes the issue where a window that is created without decorations will have decorations when quickly maximizing and then un-maximizing the window.

The fix has been in trunk for some time with no regressions.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-5.0-autolanding/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-5.0-precise-amd64-autolanding/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2415
http://jenkins.qa.ubuntu.com/job/unity-5.0-ci/1/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-5.0-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Mrazik (mrazik) wrote :

Can you please merge manually (as far as I can see some older MP were merged manually anyway)?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-5.0-autolanding/2/
Executed test runs:
    None: http://jenkins.qa.ubuntu.com/job/unity-5.0-precise-amd64-autolanding/2/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches