Merge lp://qastaging/~tpeeters/ubuntu-ui-toolkit/landscapeHeader into lp://qastaging/ubuntu-ui-toolkit/staging
Proposed by
Tim Peeters
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Cris Dywan | ||||
| Approved revision: | 1736 | ||||
| Merged at revision: | 1770 | ||||
| Proposed branch: | lp://qastaging/~tpeeters/ubuntu-ui-toolkit/landscapeHeader | ||||
| Merge into: | lp://qastaging/ubuntu-ui-toolkit/staging | ||||
| Diff against target: |
21 lines (+3/-1) 1 file modified
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+3/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~tpeeters/ubuntu-ui-toolkit/landscapeHeader | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Cris Dywan | Approve | ||
|
Review via email:
|
|||
Commit message
Reduce the PageHeader height by 1 GU on phone in landscape orientation.
Description of the change
Reviewed at the sprint with Olga, Ben, Jouni.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
For the record, I think it should be clarified that we only want this for the small phone screen - and not for the windowed mode where you might have a small window. Otherwise this will need to be adjusted later - but for now I see no issue having this regardless.