Merge lp://qastaging/~trb143/openlp/cleanups02182 into lp://qastaging/openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: 2814
Proposed branch: lp://qastaging/~trb143/openlp/cleanups02182
Merge into: lp://qastaging/openlp
Diff against target: 709 lines (+161/-60)
18 files modified
openlp/core/api/endpoint/controller.py (+3/-3)
openlp/core/common/__init__.py (+8/-8)
openlp/core/lib/serviceitem.py (+8/-1)
openlp/core/ui/firsttimewizard.py (+0/-14)
openlp/core/ui/media/mediacontroller.py (+0/-1)
openlp/core/ui/servicemanager.py (+4/-12)
openlp/core/ui/slidecontroller.py (+20/-6)
openlp/core/ui/thememanager.py (+2/-2)
openlp/core/widgets/toolbar.py (+11/-5)
openlp/core/widgets/views.py (+9/-2)
openlp/plugins/custom/lib/mediaitem.py (+24/-0)
openlp/plugins/songs/lib/db.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+29/-0)
openlp/plugins/songs/lib/songstab.py (+11/-0)
openlp/plugins/songs/songsplugin.py (+1/-0)
scripts/websocket_client.py (+1/-0)
tests/functional/openlp_core/api/endpoint/test_controller.py (+25/-3)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~trb143/openlp/cleanups02182
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+341574@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2018-03-16.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Been coding a lot in C recently? ;-)

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

A couple of fixes I missed the first time

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.