Merge lp://qastaging/~trb143/openlp/localserver into lp://qastaging/openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: 2816
Proposed branch: lp://qastaging/~trb143/openlp/localserver
Merge into: lp://qastaging/openlp
Diff against target: 633 lines (+405/-77)
8 files modified
openlp/.version (+1/-1)
openlp/core/app.py (+21/-25)
openlp/core/common/i18n.py (+1/-1)
openlp/core/server.py (+109/-0)
openlp/core/version.py (+6/-42)
tests/functional/openlp_core/api/http/test_init.py (+151/-0)
tests/functional/openlp_core/test_app.py (+2/-8)
tests/functional/openlp_core/test_server.py (+114/-0)
To merge this branch: bzr merge lp://qastaging/~trb143/openlp/localserver
Reviewer Review Type Date Requested Status
Tomas Groth Approve
Review via email: mp+342804@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2018-04-05.

Commit message

Replace the Memory check with a local server which stops and starts correctly.
One the 2nd instance pass the service file if one is included
Stop the 2nd instance starting as it will fail due to port clashes and a monster thread issue(may be connected).
Removed redundant code
Add a number of new tests.

Description of the change

Replace the Memory check with a local server which stops and starts correctly.
One the 2nd instance pass the service file if one is included
Stop the 2nd instance starting as it will fail due to port clashes and a monster thread issue(may be connected).
Removed redundant code
Add a number of new tests.

lp:~trb143/openlp/localserver (revision 2850)
https://ci.openlp.io/job/Branch-01-Pull/2501/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2402/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/188/ [FAILURE]
https://ci.openlp.io/job/Branch-03a-Build-Source/100/ [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-macOS/93/ [SUCCESS]
https://ci.openlp.io/job/Branch-04a-Code-Analysis/1562/ [SUCCESS]
https://ci.openlp.io/job/Branch-04b-Test-Coverage/1375/ [SUCCESS]

To post a comment you must log in.
Revision history for this message
Tomas Groth (tomasgroth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.