Merge lp://qastaging/~trent-trentonadams/backintime/human-readable into lp://qastaging/backintime/1.0
| Status: | Rejected |
|---|---|
| Rejected by: | Germar |
| Proposed branch: | lp://qastaging/~trent-trentonadams/backintime/human-readable |
| Merge into: | lp://qastaging/backintime/1.0 |
| Diff against target: |
125 lines (+35/-1) 5 files modified
common/config.py (+6/-0) common/tools.py (+3/-0) gnome/settingsdialog.glade (+14/-1) gnome/settingsdialog.py (+7/-0) kde4/settingsdialog.py (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~trent-trentonadams/backintime/human-readable |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Germar | Disapprove | ||
|
Review via email:
|
|||
Description of the change
I've added rsync --human-readable support
- modified gnome and kde applications to set the configuration
- tested both gnome and kde applications, making sure they can toggle human_readable flag in ~/.config/
- backup runs with --human-readable.
I think this is a simple enough change to consider it "stable".
I wanted this feature so that when I twitter the summary of how much data was transferred, it is easily readable.
For example, now I get this...
sent 150.30M bytes received 2.62M bytes 719.59K bytes/sec
Instead of something like this...
sent 150123456 bytes received 2621325 bytes 719591 bytes/sec
I grab the 150M awk, and send that value out with my tweet.
| Trenton D. Adams (trent-trentonadams) wrote | # |
Unmerged revisions
- 783. By Trenton D. Adams
-
- and apparently they use tabs
- 782. By Trenton D. Adams
-
- oops, removed use_checksum capability by accident
- 781. By Trenton D. Adams
-
- add --human-readable support for kde app
- 780. By Trenton D. Adams
-
- add rsync --human-readable support
oops, I accidentally messed up the kde app by removing checksum capability. Should I cancel this merge request, and make a new one?