Juju Charms Collection
storage package

Merge lp://qastaging/~tribaal/charms/precise/storage/add-ceph-storage-provider into lp://qastaging/charms/storage

  1. Precise Pangolin (12.04)
  2. add-ceph-storage-provider
  3. Merge into trunk
Proposed by Chris Glass
Status: Work in progress
Proposed branch: lp://qastaging/~tribaal/charms/precise/storage/add-ceph-storage-provider
Merge into: lp://qastaging/charms/storage
Diff against target: 2112 lines (+1834/-27)
19 files modified
.bzrignore (+1/-0)
Makefile (+9/-9)
charm-helpers.yaml (+1/-0)
hooks/ceph_common.py (+12/-0)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+387/-0)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+111/-6)
hooks/charmhelpers/core/host.py (+85/-12)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+305/-0)
hooks/charmhelpers/core/services/helpers.py (+125/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+394/-0)
hooks/charmhelpers/fetch/archiveurl.py (+63/-0)
hooks/charmhelpers/fetch/bzrurl.py (+50/-0)
hooks/storage-provider.d/ceph/ceph-relation-changed (+69/-0)
hooks/storage-provider.d/ceph/config-changed (+6/-0)
hooks/storage-provider.d/ceph/data-relation-changed (+45/-0)
metadata.yaml (+2/-0)
To merge this branch: bzr merge lp://qastaging/~tribaal/charms/precise/storage/add-ceph-storage-provider
Reviewer Review Type Date Requested Status
David Britton (community) Needs Information
Review via email: mp+232239@code.qastaging.launchpad.net

Description of the change

This branch adds basic support for a "ceph" storage provider that mounts and uses a ceph image to use as storage.

It is currently rough (not working 100%), but I'd like to have eyes on the code before I go any further with it (I don't understand exactly what's wrong with my approach).

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

Chris, just on first glance it seems you are missing the ceph-relation-changed hook symlink in the hooks directory. Those hooks are needed as links to hooks/hooks as it is a proxy for calls to the underlying storage-provider.d/<provider_name>/your-hook-name. If the hook symlink doesn't exist at hooks/ceph-relation-changed you should see a "no ceph-relation-changed hook" message in the juju logs.

I'll peek more at this on with a live deployment.

Reply
lp://qastaging/~tribaal/charms/precise/storage/add-ceph-storage-provider updated
44. By Chris Glass

Added ceph-relation-changed hook symlink.

45. By Chris Glass

Make the ceph-relation-changed hook noop if all the necessary information is
not present (like the key).

46. By Chris Glass

added relation debug output

Revision history for this message
David Britton (dpb) wrote :

Hi Chris -- Thanks so much for doing this!

The general approach looks great. Can you implement the data-relation-departed hook as well? I noticed an 'unmount' commented out import in the data-relation-changed hook as well, thought maybe you were thinking about doing that when you stopped for a quick sanity-check.

Before I run through paces, I wanted to make sure that you include a sample deployment when working with ceph at least here in the review so we can compare apples to apples.

Also I added a simple nit for a diff comment.

This change is quite exciting, glad so much of it is contained in charmhelpers. :)

review: Needs Information
Reply
Revision history for this message
Chris Glass (tribaal) wrote :

Yes, I started working on the unmount logic, but then realised this branch was already 2k lines, so I decided against putting even more code in.

I'll add it in here, no problem.

Reply
lp://qastaging/~tribaal/charms/precise/storage/add-ceph-storage-provider updated
47. By Chris Glass

Added exit(0)!

Unmerged revisions

47. By Chris Glass

Added exit(0)!

46. By Chris Glass

added relation debug output

45. By Chris Glass

Make the ceph-relation-changed hook noop if all the necessary information is
not present (like the key).

44. By Chris Glass

Added ceph-relation-changed hook symlink.

43. By Chris Glass

Added some debug logs...

42. By Chris Glass

Added logs to the data-relation-changed hook

41. By Chris Glass

Put the common ceph code in a proper python module.

40. By Chris Glass

Made hook executable. Duh.

39. By Chris Glass

Update charm-helpers along with the make file to sync them.

38. By Chris Glass

The hooks should work

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: