Merge lp://qastaging/~tribaal/charms/trusty/landscape-client/put-install-hook-in-its-own-file into lp://qastaging/charms/trusty/landscape-client
Proposed by
Chris Glass
| Status: | Merged |
|---|---|
| Merged at revision: | 43 |
| Proposed branch: | lp://qastaging/~tribaal/charms/trusty/landscape-client/put-install-hook-in-its-own-file |
| Merge into: | lp://qastaging/charms/trusty/landscape-client |
| Diff against target: |
197 lines (+90/-71) 2 files modified
hooks/hooks.py (+0/-71) hooks/install.py (+90/-0) |
| To merge this branch: | bzr merge lp://qastaging/~tribaal/charms/trusty/landscape-client/put-install-hook-in-its-own-file |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Collard (community) | Approve | ||
| Fernando Correa Neto (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch takes the install hook out to its own file, to prevent the install hook from depending on the landscape client code (that should by definition not be installed).
It did not create a problem so far because by default the cloud images have the landscape-common package installed. It will be a problem if the client's API changes in the future.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice! Still works +1