Merge lp://qastaging/~tribaal/landscape-charm/source-ux-improvements into lp://qastaging/~landscape/landscape-charm/trunk

Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 320
Merged at revision: 318
Proposed branch: lp://qastaging/~tribaal/landscape-charm/source-ux-improvements
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 77 lines (+23/-3)
4 files modified
config.yaml (+6/-2)
lib/apt.py (+6/-0)
lib/tests/test_apt.py (+10/-0)
metadata.yaml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~tribaal/landscape-charm/source-ux-improvements
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Alberto Donato (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+262723@code.qastaging.launchpad.net

Commit message

Add simple support for version numbers as PPA URL shortcuts.

Description of the change

This branch adds simple support for version numbers as PPA URL shortcuts.

It is using a regexp to prevent having to maintain a whitelist.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 319
Branch: lp:~tribaal/landscape-charm/source-ux-improvements
Jenkins: https://ci.lscape.net/job/latch-test/1547/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

Looks good, +1

One small nit inline

review: Approve
Revision history for this message
Chris Glass (tribaal) :
Revision history for this message
Adam Collard (adam-collard) :
review: Needs Information
320. By Chris Glass

Narrowed down the regexp as suggested.

Revision history for this message
Chris Glass (tribaal) wrote :

All comments should be addressed.

Revision history for this message
Adam Collard (adam-collard) wrote :

Thanks! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches