lp://qastaging/~tribaal/landscape-client/remove-mocker-broker-client

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/~landscape/landscape-client/trunk at revision 886

🤖 Landscape Builder: Approve (test results) on 2016-06-16

Bogdana Vereha (community): Approve on 2016-06-15

Geoff Teale (community): Approve on 2016-06-15

Diff: 255 lines (+51/-53)

1 file modified

landscape/broker/tests/test_client.py (+51/-53)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1592875: remove mocker

Medium

Fix Committed

Link a bug report

Related blueprints

874. By Chris Glass on 2016-06-16

Merge trunk

873. By Chris Glass on 2016-06-15

Fixed review comment

872. By Chris Glass on 2016-06-15

s/mocker/mock/

871. By Данило Шеган on 2016-06-15

Merge mock-tests-sysinfo [f=1592875] [r=landscape-builder,adam-collard,bogdana] [a=Данило Шеган]
Move landscape/sysinfo/tests/test_sysinfo.py to mock.

870. By Bogdana Vereha on 2016-06-15

Merge mocker-monitor-test-usermonitor [f=1592875] [r=chad.smith,free.ekanayaka,landscape-builder] [a=Bogdana Vereha]
Update monitor.tests.test_usermonitor to use mock instead of mocker

869. By Chad Smith on 2016-06-15

Merge mocker-to-mock-activeprocess [f=1592875] [r=landscape-builder,adam-collard,simpoir] [a=Chad Smith]
Mocker to mock activeprocess unit tests.

868. By Bogdana Vereha on 2016-06-15

Merge mocker-monitor-test-service [f=1592875] [r=chad.smith,danilo,landscape-builder] [a=Bogdana Vereha]
Update monitor.tests.test_service to use mock

867. By Chris Glass on 2016-06-15

Merge remove-mocker-computerinfo [f=1592875] [r=danilo,bogdana,landscape-builder] [a=Chris Glass]
s/mocker/mock/

866. By Chad Smith on 2016-06-15

Merge mocker-to-mock-computer-uptime [f=1592875] [r=simpoir,free.ekanayaka,landscape-builder,chad.smith] [a=Chad Smith]
Replace use of mocker with python mock in computeruptime tests.

865. By Данило Шеган on 2016-06-15

Merge mock-tests-broker-exchange [f=1592875] [r=landscape-builder,free.ekanayaka,tribaal] [a=Данило Шеган]
Kill mocker use in landscape/broker/tests/test_exchange.py

I am not too happy about mocking the private exchange._reactor in the second test: since it's set-up in setUp, the only alternative I see is to re-create it like the first test does.