Merge lp://qastaging/~tribaal/livecd-rootfs/xenial-proposed-vagrant-user-changes into lp://qastaging/~ubuntu-core-dev/livecd-rootfs/xenial-proposed

Proposed by Chris Glass
Status: Merged
Merged at revision: 1450
Proposed branch: lp://qastaging/~tribaal/livecd-rootfs/xenial-proposed-vagrant-user-changes
Merge into: lp://qastaging/~ubuntu-core-dev/livecd-rootfs/xenial-proposed
Diff against target: 80 lines (+30/-11)
2 files modified
debian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+23/-11)
To merge this branch: bzr merge lp://qastaging/~tribaal/livecd-rootfs/xenial-proposed-vagrant-user-changes
Reviewer Review Type Date Requested Status
Łukasz Zemczak non-cpc Approve
David Britton (community) Approve
Philip Roche (community) Approve
Review via email: mp+334921@code.qastaging.launchpad.net

Description of the change

This branch is a backport to Xenial of the changes already in Artful/Bionic with regard to the default user layout of our produced vagrant box.

The equivalent trunk (at the time) commit is https://bazaar.launchpad.net/~ubuntu-core-dev/livecd-rootfs/trunk/revision/1504

Some more information (including the SRU template) can be found in the linked bug.

To post a comment you must log in.
Revision history for this message
Philip Roche (philroche) wrote :

Changes LGTM.

review: Approve
Revision history for this message
David Britton (dpb) wrote :

Inline comment about dropping the ubuntu user.

review: Needs Information
Revision history for this message
Chris Glass (tribaal) wrote :

Answered inline - the ubuntu user is not being dropped.

Revision history for this message
David Britton (dpb) :
review: Approve
1451. By Chris Glass

debian/changelog should target UNRELEASED until actually released.

1452. By Chris Glass

Made changelog entry more explicit.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Dreadful. +1

review: Approve (non-cpc)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches