Scratch

Merge lp://qastaging/~trojan295/scratch/plugin-crash into lp://qastaging/~elementary-apps/scratch/scratch

  1. plugin-crash
  2. Merge into scratch
Proposed by Damian Czaja
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://qastaging/~trojan295/scratch/plugin-crash
Merge into: lp://qastaging/~elementary-apps/scratch/scratch
Diff against target: 0 lines
To merge this branch: bzr merge lp://qastaging/~trojan295/scratch/plugin-crash
Reviewer Review Type Date Requested Status
Jeremy Wootten Needs Fixing
xapantu (community) Needs Fixing
Review via email: mp+263842@code.qastaging.launchpad.net

Description of the change

Crashing was caused by not disconnecting signals, when disabling some plugins. After toggling a plugin hundreds of times, there were hundreds connections. Added disconnecting the signals when disabling the plugins and now it should work fine.

To post a comment you must log in.
lp://qastaging/~trojan295/scratch/plugin-crash updated
1524. By Danielle Foré

Use "Line Wrap" instead of "Split long text.." string

1525. By Cody Garver

Updated translation template

1526. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1527. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1528. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1529. By James

Add plugin for preserving indent level when copy-pasting text (lp:1039278)

1530. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1531. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1532. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1533. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1534. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1535. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1536. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1537. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1538. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1539. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1540. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1541. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1542. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1543. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1544. By mporten

Fix bug #1467148: Changed bold sections in Preferences Dialog to h4

Revision history for this message
xapantu (xapantu) wrote :

Thanks for the investigation!

However, this part of the code:
this.split_view.document_change.connect ((doc) => { plugins.hook_document (doc); });

Only needs to be done once, at the start of the code. It is not needed to disconnect/reconnect it everytime hook_func is called.

(I am not sure what this whole delegate stuff is about by the way, it looks like to be a rather bad design, but that's out of the scope of this merge request.)

review: Needs Fixing
lp://qastaging/~trojan295/scratch/plugin-crash updated
1545. By Alex Ordonez

Fix debug typos in SplitView Widget.

1546. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1547. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1548. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1549. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1550. By Cody Garver

Release 2.2.1

1551. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1552. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1553. By Artem Anufrij

Scratch crashes after changing location of terminal

1554. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1555. By Corentin Noël

* Changed a lot of code style to comply with the elementary HIG
* Removed some warnings with unhandled Errors
* Used "switch" instead of multiple "else if"
* Used for (x;x;x) instead of multiple lines with while
* Used lock (var) {} instead of var_lock mutex in the word completion plugin
* Used Thread.try instead of the deprecated Thread.create in the word completion plugin
* Used Gee.List instead of GLib.List, because it's better for the ref count in Vala

1556. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1557. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1558. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1559. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1560. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1561. By Florian Angermeier

Close the search bar by pressing the escape key

1562. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1563. By Corentin Noël

- Removed some deprecated widgets.
- Reorganized the toolbar.
- Search button is now a ToggleToolButton as seen in pantheon-terminal.
- Fix a widget being packed twice on the toolbar.
- Use more native toolitems in the search toolbar, added cyclic search.

1564. By Cody Garver

Updated translation template

1565. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1566. By Cody Garver

Fix browser-preview plugin Module name

1567. By Cody Garver

Fix pastebin plugin Module name

1568. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1569. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1570. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1571. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1572. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1573. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1574. By Gero.Bare

Cast dialog content area as box to pack scroll. Fixes runtime warning.

1575. By Gero.Bare

Add checks in ScratchApp to ensure files passed through cli are proper files.

1576. By Gero.Bare

Fix SourceView language highlight selection.

If you had a highlight style selected you couldn't change back to "Normal Text" mode due a null check.

1577. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1578. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1579. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1580. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1581. By The Lemon Man

Fixes bug #1080904. Now Scratch save tab order for saved files.

1582. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1583. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1584. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1585. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1586. By Gero.Bare

Fix missing link directive link_libraries in pastebin's CMakelist.txt
Fix SessionSync deprecation warning in pastebin compilation.

1587. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1588. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1589. By Gero.Bare

Move tab to new window from main loop

1590. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1591. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

Revision history for this message
Gero.Bare (gero-bare) wrote :

@xapantu

No that doesn't work.

I don't know I think this is fine. Considering this is potentially a serious bug this is a great improvement.

Can you reconsider it?

lp://qastaging/~trojan295/scratch/plugin-crash updated
1592. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1593. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1594. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1595. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1596. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1597. By Leonardo Lemos

Make plugins translatable (lp:1187310)

1598. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1599. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1600. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1601. By Danielle Foré

add appdata.xml

1602. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1603. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1604. By Leonardo Lemos

Use translator-credits to credit translators (lp:1344887)

1605. By Gero.Bare

Remember the language dictionary used by the spellcheck between sessions

1606. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1607. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1608. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1609. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1610. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1611. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1612. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1613. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1614. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1615. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1616. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1617. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1618. By Corentin Noël

Use the new valadoc.org icons

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

I confirm that this branch fixes the bug, which is still present in the current trunk.

Apart from minor code style issues (see inline comments) I approve.

review: Approve
Revision history for this message
Damian Czaja (trojan295) wrote :

I will try to improve the code according to your guidelines and push it today.

I will also check, if xapantu is right, but I think, that the signal has to be disconnected every plugin disable. In the current Scratch release every enabling of a plugin is connecting a new signal, which is not disconnected after disabling the plugins and this causes a leak. So every time we disable a plugin we need to release the signal connections.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Thanks Damian, I think you are right but either way, if the fix works I
think it should be merged even if it maybe slightly sub-optimal - its not
worth holding it up if it has no adverse side-effects.

On 15 January 2016 at 13:30, Damian Czaja <email address hidden> wrote:

> I will try to improve the code according to your guidelines and push it
> today.
>
> I will also check, if xapantu is right, but I think, that the signal has
> to be disconnected every plugin disable. In the current Scratch release
> every enabling of a plugin is connecting a new signal, which is not
> disconnected after disabling the plugins and this causes a leak. So every
> time we disable a plugin we need to release the signal connections.
> --
> https://code.launchpad.net/~trojan295/scratch/plugin-crash/+merge/263842
> You are reviewing the proposed merge of lp:~trojan295/scratch/plugin-crash
> into lp:scratch.
>

lp://qastaging/~trojan295/scratch/plugin-crash updated
1619. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1620. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1621. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

There are now conflicts with trunk that need resolving.

review: Needs Fixing
lp://qastaging/~trojan295/scratch/plugin-crash updated
1622. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1623. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1624. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1625. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1626. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

1627. By Pranav Sharma

Update Help link to elementary.io URL (lp:1456733)

1628. By Damian Czaja <email address hidden>

Fixed crashing Scratch after many extension toggles.

Revision history for this message
Damian Czaja (trojan295) wrote :

The current branch should be able to be merged into trunk.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

It looks like the branch also stripped whitespace in unrelated places, making the diff huge.

Unmerged revisions

1628. By Damian Czaja <email address hidden>

Fixed crashing Scratch after many extension toggles.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches