Merge ~tsimonq2/launchpad:buildinfo-lp1686242 into launchpad:master

Proposed by Simon Quigley
Status: Needs review
Proposed branch: ~tsimonq2/launchpad:buildinfo-lp1686242
Merge into: launchpad:master
Diff against target: 46 lines (+7/-5)
2 files modified
lib/lp/archiveuploader/dscfile.py (+2/-0)
lib/lp/archiveuploader/nascentupload.py (+5/-5)
Reviewer Review Type Date Requested Status
Colin Watson (community) Needs Fixing
Review via email: mp+448527@code.qastaging.launchpad.net

Commit message

Include buildinfo files in source and binary records for an upload (LP: #1686242)

When buildinfo files are uploaded, either by the packager or the buildd daemon,
they are stored by the librarian but not referenced in SourcePackageReleaseFile or
BinaryPackageFile appropriately. This adds the appropriate references, allowing the
files to be shown on the page.

Description of the change

Include buildinfo files in source and binary records for an upload (LP: #1686242)

When buildinfo files are uploaded, either by the packager or the buildd daemon, they are stored by the librarian but not referenced in SourcePackageReleaseFile or BinaryPackageFile appropriately. This adds the appropriate references, allowing the files to be shown on the page.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

This needs unit tests, for example webui tests to check these files appear.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

It would be best to be able to publish it in the apt archive maybe somehow.

Revision history for this message
Colin Watson (cjwatson) wrote :

I don't think this is the right approach. The buildinfo is already linked to the `SourcePackageRelease`/`BinaryPackageBuild` using dedicated columns, so we shouldn't make extra links for it via `SourcePackageReleaseFile`/`BinaryPackageFile` (especially not as a "generic" file). Instead, the API/UI layers should be changed to provide some way to get at the data that's already stored.

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: