Merge ~twom/launchpad:oci-policy-push-tags-to-the-limit into launchpad:master
Proposed by
Tom Wardill
| Status: | Rejected |
|---|---|
| Rejected by: | Tom Wardill |
| Proposed branch: | ~twom/launchpad:oci-policy-push-tags-to-the-limit |
| Merge into: | launchpad:master |
| Diff against target: |
116 lines (+49/-1) 3 files modified
lib/lp/oci/interfaces/ocipushrule.py (+9/-0) lib/lp/oci/model/ocipushrule.py (+14/-0) lib/lp/oci/tests/test_ocipushrule.py (+26/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thiago F. Pappacena (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2020-12-07.
Commit message
Add tag support to OCIPushRule
Description of the change
Use the text[] column for tags to add tag support to OCIPushRule.
No validation on the tags other than uniqueness, and the tags aren't currently used on push. This is just model and interface support.
Can't land until after https:/
To post a comment you must log in.
Revision history for this message
| Tom Wardill (twom) | # |
Revision history for this message
| Thiago F. Pappacena (pappacena) | # |
review:
Approve
Revision history for this message
| Tom Wardill (twom) | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. Added just a couple of minor possible improvements.