Ubuntu Clock App

Merge lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433 into lp://qastaging/ubuntu-clock-app

  1. 1350433
  2. Merge into trunk
Proposed by twstd
Status: Rejected
Rejected by: Nekhelesh Ramananthan
Proposed branch: lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433
Merge into: lp://qastaging/ubuntu-clock-app
Diff against target: 176 lines (+68/-14)
4 files modified
backend/modules/Timezone/generictimezonemodel.cpp (+1/-1)
backend/modules/Timezone/timezonemodel.cpp (+29/-11)
backend/modules/Timezone/timezonemodel.h (+36/-0)
backend/modules/Timezone/xmltimezonemodel.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan Disapprove
Review via email: mp+230211@code.qastaging.launchpad.net

Description of the change

Fix for #1350433
https://bugs.launchpad.net/ubuntu-clock-app/+bug/1350433

To post a comment you must log in.
lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433 updated
45. By twstd

Fix seg fault if cities have been already added and cut to 40ms

Revision history for this message
twstd (twstd-dev) wrote :

I've managed to cut the loading time to 40ms in VM and fixed segmentation fault, that occurs if you have some cities already added to the main page.

lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433 updated
46. By twstd

Add comments

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

There is an issue in the worldcity page where the time doesn't update once the page is loaded. So it doesn't respect the updateInterval property. I set that property to 1 min to improve the performance while at the same time keeping accuracy. But now the only way to see updated times is to close the world city page and reopen the page.

However the times in the main clock app update as expected.

review: Needs Fixing
lp://qastaging/~twstd-dev/ubuntu-clock-app/1350433 updated
47. By twstd

Fix time won't being updated on the cities list

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

We have already fixed this in another MP and also landed it in trunk.

Revision history for this message
Nekhelesh Ramananthan (nik90) :
review: Disapprove

Unmerged revisions

47. By twstd

Fix time won't being updated on the cities list

46. By twstd

Add comments

45. By twstd

Fix seg fault if cities have been already added and cut to 40ms

44. By twstd

Optimize date retrieveal in data model

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: