LAVA Dispatcher

Merge lp://qastaging/~tyler-baker/lava-dispatcher/dummy-deploy-fix into lp://qastaging/lava-dispatcher

dummy-deploy-fix
Merge into trunk

Proposed by Tyler Baker on 2013-09-10

Status:	Merged
Merged at revision:	676
Proposed branch:	lp://qastaging/~tyler-baker/lava-dispatcher/dummy-deploy-fix
Merge into:	lp://qastaging/lava-dispatcher
Diff against target:	9 lines (+0/-1) 1 file modified lava_dispatcher/actions/deploy.py (+0/-1)
To merge this branch:	bzr merge lp://qastaging/~tyler-baker/lava-dispatcher/dummy-deploy-fix
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Antonio Terceiro		Approve on 2013-09-10
Dave Pigott	2013-09-10	Approve on 2013-09-10
Review via email: mp+184791@code.qastaging.launchpad.net

Description of the change

A true dummy_deploy should not have a dependancy on a master image. It should load the deployment data and finish.

Revision history for this message

Dave Pigott (dpigott) wrote on 2013-09-10:

review: Approve

Revision history for this message

Antonio Terceiro (terceiro) wrote on 2013-09-10:

On Tue, Sep 10, 2013 at 02:35:38PM -0000, Tyler Baker wrote:
> A true dummy_deploy should not have a dependancy on a master image. It
> should load the deployment data and finish.

I was thinking that one needs to be aware that with this change, if you
run a job with dummy_deploy against a device which does have a master
image, that the tests *may* run in the master image ... but then the
logic in e.g. lava_test_shell should already make sure the proper master
image/test image switching already takes place anyway, so +1

review approve

review: Approve