Merge lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/ViewRedisign into lp://qastaging/ubuntu-calendar-app

@Mihir, Week View needs fixing, as of rev 471, it looks like https://imgur.com/imB1lyd on the emulator. I am pretty sure on the phone, the week day names will collide with one other. Also the events seems shifted.

@Nik,

Yes, I guess now the only option left is , we might have to overlap hours.

FAILED: Continuous integration, rev:478
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/807/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2035/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/365/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/807/rebuild

PASSED: Continuous integration, rev:479
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/808/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2036
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2036/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/366

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/808/rebuild

PASSED: Continuous integration, rev:480
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/809/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2037
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2037/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/367

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/809/rebuild

PASSED: Continuous integration, rev:481
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/810/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/368

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/810/rebuild

FAILED: Continuous integration, rev:482
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/815/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/375
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/375/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/373

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/815/rebuild

Something goes wrong with Dayview , it is not visible ,

http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/375/artifact/calendar_app.tests.test_dayview.TestDayView.test_current_month_and_year_is_selected.ogv

> Something goes wrong with Dayview , it is not visible ,
>
> http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/375/artifact/c
> alendar_app.tests.test_dayview.TestDayView.test_current_month_and_year_is_sele
> cted.ogv

I forgot to add qtdeclarative5-quicklayouts-plugin as a dependency in the debian/control file which caused the day view to not load in jenkins. I fixed it. Everything should be fine.

I reverted the All Day Event file change due to the regression in the week view we discussed.

PASSED: Continuous integration, rev:485
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/816/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/378
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/378/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/374

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/816/rebuild

this MR is too large for me to review, Can we break down it more manageable and with only relevant code change applied.

There are higher chance of regression, as both testing and review is difficult.

Also added one minor comment

Hi Kunal,

With respect to your comment , yes we have removed the partial views of next and previous day now as we moved days in header,so only one day will be visible in Dayview.

> Hi Kunal,
>
> With respect to your comment , yes we have removed the partial views of next
> and previous day now as we moved days in header,so only one day will be
> visible in Dayview.

Changes are fine to me if others know about it and fine with it, please take popey's comment regarding same.

BTW, it does not seem to be a valid reason to remove those view's just because we moved day's to header. There are other alternative also.

What we are doing in weekview ? We can apply same comment here as well.

Hey Kunal,

1. We are in the process of splitting this MR into several smaller ones for easier review and testing as you are right, big MPs can lead to regressions slipping in.

2. At every stage of the implementation of the redesign of the views, we made sure to get feedback from popey. And we believe that a day view should be a day view showing the events of only that day for several reasons,

- By showing only a single day, we provide more room to show events of that particular day which would otherwise be cramped. If a user wants to see the days in the other days then he/she can use the week view.

- On the phone the screen estate is really precious, by showing only that day's event in the day view, we are simplifying the view for the user and it has resulted in a much cleaner design in my honest opinion.

Again this was approved by popey.

I am not sure if you tried this on the phone, but it looks gorgeous so I hope you would agree to this change.

> Hey Kunal,
>
> 1. We are in the process of splitting this MR into several smaller ones for
> easier review and testing as you are right, big MPs can lead to regressions
> slipping in.

Thanks, this really helps a lot.
>
> 2. At every stage of the implementation of the redesign of the views, we made
> sure to get feedback from popey. And we believe that a day view should be a
> day view showing the events of only that day for several reasons,
>
> - By showing only a single day, we provide more room to show events of that
> particular day which would otherwise be cramped. If a user wants to see the
> days in the other days then he/she can use the week view.
>
> - On the phone the screen estate is really precious, by showing only that
> day's event in the day view, we are simplifying the view for the user and it
> has resulted in a much cleaner design in my honest opinion.
>
> Again this was approved by popey.
>
> I am not sure if you tried this on the phone, but it looks gorgeous so I hope
> you would agree to this change.

I am fine with it, if popey agrees with the change.

I had one concern though (based on snapshot you posted), this change makes WeekView and DayView look different.In my personal opinion both should look and behave same, to me its part of same view, one is compressed and other is not.

> I am fine with it, if popey agrees with the change.
>
> I had one concern though (based on snapshot you posted), this change makes
> WeekView and DayView look different.In my personal opinion both should look
> and behave same, to me its part of same view, one is compressed and other is
> not.

The weekview and dayview resemble each other quite a bit UI wise. The only differences we did are the following,

- Day view shows only its day events (expanded) while week view shows multiple day events (compressed)
- In day view we do not show the week days and date header since it is rather redundant to show only one day.

Otherwise everything remains the same. The All-Day events have not changed. The UI is very similar.

This branch has been splitted into multiple branches and merged to trunk for reference :-

[1]https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/1-RemovedDuplicateHeaders
[2]https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/2-Improve-WeekView
[3]https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/3-Improve-DayView
[4]https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/4-Improve-Month-Year-View

hence disapproving this branch.