Ubuntu Calendar App

Merge lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page into lp://qastaging/ubuntu-calendar-app

revamp-newevent-page
Merge into trunk

Proposed by Mihir Soni on 2014-09-04

Status:

Merged

Approved by:

Nekhelesh Ramananthan on 2014-09-09

Approved revision:

425

Merged at revision:

441

Proposed branch:

lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page

Merge into:

lp://qastaging/ubuntu-calendar-app

Diff against target:

1445 lines (+774/-434)

8 files modified

EventReminder.qml (+85/-0)
EventRepetition.qml (+246/-0)
EventUtils.qml (+103/-0)
NewEvent.qml (+308/-422)
NewEventEntryField.qml (+17/-3)
RecurrenceLabelDefines.qml (+7/-5)
calendar.qml (+1/-1)
tests/autopilot/calendar_app/__init__.py (+7/-3)

To merge this branch:

bzr merge lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page

Related bugs:

Bug #1317908: Field label/hint within field content is not intuitive	Medium	Fix Released
Bug #1359135: Labels compress lists on NewEvent.qml for narrow screens.	Medium	Fix Released
Bug #1364989: Calendar names need to be ellided or support multiline in the "New event" view	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-09-09
Nekhelesh Ramananthan		2014-09-04	Approve on 2014-09-09
Alan Pope 🍺🐧🐱 🦄 (community)			Approve on 2014-09-09
Kunal Parmar		2014-09-04	Needs Fixing on 2014-09-06
Nicholas Skaggs (community)			Needs Fixing on 2014-09-05
Review via email: mp+233414@code.qastaging.launchpad.net

Commit message

Redesigned New Event Page.

Description of the change

Redesigned New Event Page.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-04:

FAILED: Continuous integration, rev:419
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/745/
Executed test runs:
FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1893/console
FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/303/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/745/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-09-04:

Added some inline comments.

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-09-04:

I did a rather quick code review. I still need to to do an extensive code review + testing on device. But I can only do that tomorrow. But please do not merge before that.

Also kunal needs to approve as well!

review: Needs Fixing

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-05:

This will need re-merged with trunk.

review: Needs Fixing

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2014-09-06:

gone through briefly, added few comments

Revision history for this message

Kunal Parmar (pkunal-parmar) wrote on 2014-09-06:

i need to test it also

review: Needs Fixing

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-06:

FAILED: Continuous integration, rev:420
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/771/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/222
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/222/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/329

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/771/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page updated on 2014-09-06

421. By Mihir Soni on 2014-09-05: review comments incorporated

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-06:

FAILED: Continuous integration, rev:421
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/772/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/223
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/223/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/330

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/772/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page updated on 2014-09-06

422. By Mihir Soni on 2014-09-06: removed emulators.py file
423. By Mihir Soni on 2014-09-06: Modified test cases with referece to balloons change

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-06:

FAILED: Continuous integration, rev:422
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/773/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/225
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/225/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/331

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/773/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-06:

PASSED: Continuous integration, rev:423
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/774/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/226
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/226/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/332

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/774/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2014-09-09:

LGTM!

review: Approve

lp://qastaging/~ubuntu-calendar-dev/ubuntu-calendar-app/revamp-newevent-page updated on 2014-09-09

424. By Nekhelesh Ramananthan on 2014-09-09: merged trunk
425. By Nekhelesh Ramananthan on 2014-09-09: Reverted accidental change to manifest file