Merge ~ubuntu-core-dev/grub/+git/ubuntu:lp.1795291 into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Steve Langasek
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 00b2d12755af8b435fcda84918ebdd9a3ee662c1
Merged at revision: 00b2d12755af8b435fcda84918ebdd9a3ee662c1
Proposed branch: ~ubuntu-core-dev/grub/+git/ubuntu:lp.1795291
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 31 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
debian/grub-check-signatures (+3/-1)
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Julian Andres Klode Needs Information
Review via email: mp+355904@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Just skipping vmlinuz binaries where .efi.signed exist seems like a better approach IMO, we can just do that by adding a

  if [ -e "$kernel.efi.signed" ]; then
   continue
  fi

before or after the dpkg check.

review: Needs Information
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

With juliank's proposed changes.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches