Merge ubiquity:kde-show-passwords into ubiquity:master
Proposed by
Łukasz Zemczak
| Status: | Merged |
|---|---|
| Merged at revision: | 8cc5fc72c6ed6f501d9ce6e4ea96280f8e9f097a |
| Proposed branch: | ubiquity:kde-show-passwords |
| Merge into: | ubiquity:master |
| Diff against target: |
135 lines (+59/-2) 4 files modified
debian/changelog (+7/-0) gui/qt/stepUserSetup.ui (+26/-1) ubiquity/frontend/kde_components/PartAuto.py (+12/-0) ubiquity/plugins/ubi-usersetup.py (+14/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rik Mills | Pending | ||
| Ubuntu Installer Team | Pending | ||
|
Review via email:
|
|||
Commit message
Add the ability to show passwords for KDE as well.
Description of the change
Add the ability to show passwords for KDE as well.
Please note that I am lacking some experience in Qt stuff, so it might be suboptimal. But I tested it and it works. I couldn't decide on the icon state appearance (what icon should it be when it's checked and when it's not..?!) but I think it's okayish - I can change that if needed.
To post a comment you must log in.
Revision history for this message
| Rik Mills (rikmills) wrote | # |
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
My pyqt5 foo is not really up to the task, so IMO perhaps merge this and fine tune later with feedback?