Merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/popoverRootItemArgument into lp://qastaging/ubuntu-ui-toolkit/staging
Proposed by
Cris Dywan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Timo Jyrinki | ||||
Approved revision: | 2101 | ||||
Merged at revision: | 2110 | ||||
Proposed branch: | lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/popoverRootItemArgument | ||||
Merge into: | lp://qastaging/ubuntu-ui-toolkit/staging | ||||
Diff against target: |
33 lines (+5/-3) 2 files modified
src/imports/Components/Pickers/1.3/PickerPanel.qml (+4/-2) src/imports/Components/Popups/1.3/popupUtils.js (+1/-1) |
||||
To merge this branch: | bzr merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/popoverRootItemArgument | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
ubuntu-sdk-build-bot | continuous-integration | Approve | |
Zsombor Egri | Approve | ||
Review via email:
|
Commit message
Try harder to pass an item to QuickUtils.rootItem
Description of the change
Adressing TypeError, more specifically, picker popups not opening because the root item is not valid.
To post a comment you must log in.
PASSED: Continuous integration, rev:2101 /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- devel/1199/ /jenkins. ubuntu. com/ubuntu- sdk/job/ generic- update- mp/6360/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- devel/1199/ rebuild
https:/