Merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/rtlBackButtonIconName into lp://qastaging/ubuntu-ui-toolkit/staging
Proposed by
Cris Dywan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Cris Dywan | ||||
| Approved revision: | 2186 | ||||
| Merged at revision: | 2187 | ||||
| Proposed branch: | lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/rtlBackButtonIconName | ||||
| Merge into: | lp://qastaging/ubuntu-ui-toolkit/staging | ||||
| Diff against target: |
27 lines (+4/-2) 2 files modified
src/imports/Components/1.3/PageStack.qml (+3/-2) src/imports/Components/1.3/ProgressionSlot.qml (+1/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/rtlBackButtonIconName | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve | |
| Adnane Belmadiaf (community) | Approve | ||
| Ubuntu SDK team | Pending | ||
|
Review via email:
|
|||
Commit message
Use layoutDirection to select icon for Back button
Description of the change
Since we don't know how long it'll take for the theme to get the missing -rtl icon (bug 1666607), and there's one precedent for this same hack with the ProgressionSlot in ListItem (bug 1672322), I decided to afterall propose a modified version of the hack using existing icon names based on the LayoutDirection.
Note that FIXMEs in the code now point to the icon theme bug reports.
To post a comment you must log in.
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1